Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Use partition table from this repo with espflash #156

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented Nov 19, 2023

What about making the partition table explicit and not relying on lucky defaults from espflash? What about integrating this together with #117 which works like a charm for me when using cargo espflash.

@ivmarkov
Copy link
Owner

ivmarkov commented Nov 19, 2023

This is only a partial solution, as this way you'll get the custom partition from rust-esp32-std-demo BUT the bottloader from espflash.

I think it should be all or nothing - either you get both from rust-esp32-std-demo, or none.

@ivmarkov
Copy link
Owner

I think either the cargo-metadata approach (assuming cargo espflash is intelligent enough to still grab the bootloader in addition to the partitions table passed via cargo-metadata), or the sdkconfig.defaults one is therefore preferred.

@sirhcel
Copy link
Contributor Author

sirhcel commented Dec 8, 2023

With what I've learned from esp-rs/esp-idf-sys#264 and esp-rs/espflash#505 (comment), I see that there is way more to it.

What yould you prefer? Closing this PR or updating it, when espflash/cargo-espflash get support for using partition and boolader from esp-rs/esp-idf-sys#264?

@sirhcel sirhcel marked this pull request as draft December 8, 2023 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants